Re: [Xen-devel] [PATCH] AMD IOMMU: correctly propagate errors from amd_iommu_init()

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On June 14, 2016 5:03 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> -    if ( amd_iommu_update_ivrs_mapping_acpi() != 0 )
> +    rc = amd_iommu_update_ivrs_mapping_acpi();
> +    if ( rc )
>          goto error_out;
> 
>      /* initialize io-apic interrupt remapping entries */
> -    if ( iommu_intremap && amd_iommu_setup_ioapic_remapping() != 0 )
> +    if ( iommu_intremap )
> +        rc = amd_iommu_setup_ioapic_remapping();
> +    if ( rc )
>          goto error_out;


Is it better to indent this if() here? Then,

+    if ( iommu_intremap )
+    {
+        rc = amd_iommu_setup_ioapic_remapping();
+        if ( rc )
+            goto error_out;
+    }

Quan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel