Re: [Xen-devel] [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.06.16 at 18:33, <konrad.wilk@xxxxxxxxxx> wrote:
>> +        /* Check for continuation if it's not the last iteration. */
>> +        if ( limit > ++bulk->start && hypercall_preempt_check() )
> 
> I surprised the compiler didn't complain to you about lack of parenthesis.

I'm puzzled - what kind of warning would you expect here? The
compiler -  afaik - treats relational operators vs logical AND/OR as
having well known precedence wrt to one another; what iirc it
would warn about is lack of parentheses in an expression using
both of the logical operators, as people frequently don't know
that && has higher precedence than ||.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel