[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 14/17] ocaml/libxs: generate a paths.ml


  • To: Wei Liu <wei.liu2@xxxxxxxxxx>
  • From: David Scott <dave@xxxxxxxxxx>
  • Date: Tue, 14 Jun 2016 21:08:59 +0100
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 14 Jun 2016 20:08:58 +0000
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=recoil.org; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= selector1; b=pPpi0E5pMyzE0irkjky73PObdoEtdMtJbD03BKBocJYFlTumK/d gDgaZEeSjtmQ8hkzGfOCoMbeEfsUYfzb1zf11D/8Wvo4w+9ZRsdGtBphA0BE2v4M fgPIIikRS6em3I06DuANO+uEh0PvSo62zTS2Pjwm2DuOLz5ypeE6cy4U=
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

> On 14 Jun 2016, at 10:36, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote:
>> 
>>> On 13 Jun 2016, at 16:22, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
>>> 
>>> On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote:
>>>> Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"):
>>>>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>>> 
>>>> FAOD I don't consider myself qualified to review this.
>>>> 
>>> 
>>> David gave his ack to a similar path so I presume he will be fine with
>>> this, too.
>>> 
>>> I will wait for his ack anyway.
>> 
>> Looks fine to me.
>> 
>> Acked-by: David Scott <dave@xxxxxxxxxx>
>> 
> 
> Thanks.
> 
> FAOD: I think this ack is only for this patch. I will hold off pushing
> this one and wait until other ocaml patches are asked.

I think I’ve acked the rest — let me know if I missed one :)

Cheers,
Dave

> 
> Wei.
> 
>> Cheers,
>> Dave
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.