[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary

To: Wei Liu <wei.liu2@xxxxxxxxxx>
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Tue, 14 Jun 2016 11:18:16 +0100
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 14 Jun 2016 10:18:33 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable when 
necessary"):
> The original code is bogus because the common case is no HA enabled.
> Setting ha variable at the beginning is not very useful.

This seems like a plausible cleanup but I don't understand why you say
the original code is `bogus'.  Is it wrong ?  If so you don't say how.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary
  - From: Wei Liu

References:
- [Xen-devel] [PATCH 0/6] xl/libxl: some cleanup / debugging aid patches
  - From: Wei Liu
- [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary
  - From: Wei Liu

Prev by Date: Re: [Xen-devel] xen/x86: efi: warning value truncated
Next by Date: Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes
Previous by thread: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary
Next by thread: Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.