Re: [Xen-devel] [PATCH v7 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.06.16 at 20:37, <suravee.suthikulpanit@xxxxxxx> wrote:
> On 6/8/2016 9:53 AM, Jan Beulich wrote:
>> diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>>> b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>>> index fce9827..4a860af 100644
>>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>>> @@ -282,6 +282,8 @@ static void __hwdom_init amd_iommu_hwdom_init(struct
>>> domain *d)
>>>
>>>      if ( !iommu_passthrough && !need_iommu(d) )
>>>      {
>>> +        int rc = 0;
>>> +
>>>          /* Set up 1:1 page table for dom0 */
>>>          for ( i = 0; i < max_pdx; i++ )
>>>          {
>>> @@ -292,12 +294,21 @@ static void __hwdom_init amd_iommu_hwdom_init(struct
>>> domain *d)
>>>               * a pfn_valid() check would seem desirable here.
>>>               */
>>>              if ( mfn_valid(pfn) )
>>> -                amd_iommu_map_page(d, pfn, pfn,
>>> -                                   IOMMUF_readable|IOMMUF_writable);
>>> +            {
>>> +                int ret = amd_iommu_map_page(d, pfn, pfn,
>>> +
>>> IOMMUF_readable|IOMMUF_writable);
>>> +
>>> +                if ( !rc )
>>> +                    rc = ret;
>>> +            }
>>>
>>>              if ( !(i & 0xfffff) )
>>>                  process_pending_softirqs();
>>>          }
>>> +
>>> +        if ( rc )
>>> +            AMD_IOMMU_DEBUG("d%d: IOMMU mapping failed: %d\n",
>>> +                            d->domain_id, rc);
>>>      }
>>>
>>>      for_each_amd_iommu ( iommu )
> 
> Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>

For the record to the list, since it had got dropped for an unknown
reason.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel