[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 10/15] flask: remove xen_flask_userlist operation



>>> On 09.06.16 at 16:47, <dgdegra@xxxxxxxxxxxxx> wrote:
> --- a/xen/include/public/xsm/flask_op.h
> +++ b/xen/include/public/xsm/flask_op.h
> @@ -70,20 +70,6 @@ struct xen_flask_transition {
>      uint32_t newsid;
>  };
>  
> -struct xen_flask_userlist {
> -    /* IN: starting SID for list */
> -    uint32_t start_sid;
> -    /* IN: size of user string and output buffer
> -     * OUT: number of SIDs returned */
> -    uint32_t size;
> -    union {
> -        /* IN: user to enumerate SIDs */
> -        XEN_GUEST_HANDLE(char) user;
> -        /* OUT: SID list */
> -        XEN_GUEST_HANDLE(uint32) sids;
> -    } u;
> -};

No known users or not, we don't normally allow breaking code that
may be consuming any of our public headers. I.e. conventionally,
for interfaces not restricted to the tool stack we keep everything,
but guard it with a __XEN_INTERFACE_VERSION__ conditional.

Whether making an exception here is okay I'm not certain; in any
event would you imo need to bump XEN_FLASK_INTERFACE_VERSION.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.