Re: [Xen-devel] [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.06.16 at 16:05, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -470,15 +470,15 @@ F:  xen/include/xsm/
>  F:  xen/xsm/
>  F:  docs/misc/xsm-flask.txt
>  
> -XSPLICE
> +LIVEPATCH
>  M:  Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>  M:  Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>  S:  Supported
> -F:  docs/misc/xsplice.markdown
> -F:  tools/misc/xen-xsplice.c
> -F:  xen/arch/*/xsplice*
> -F:  xen/common/xsplice*
> -F:  xen/include/xen/xsplice*
> +F:  docs/misc/livepatch.markdown
> +F:  tools/misc/xen-livepatch.c
> +F:  xen/arch/*/livepatch*
> +F:  xen/common/livepatch*
> +F:  xen/include/xen/livepatch*

This file is sorted, so the section should move up.

> --- a/xen/arch/arm/xsplice.c
> +++ b/xen/arch/arm/livepatch.c
> @@ -4,67 +4,67 @@
>  #include <xen/errno.h>
>  #include <xen/init.h>
>  #include <xen/lib.h>
> -#include <xen/xsplice_elf.h>
> -#include <xen/xsplice.h>
> +#include <xen/livepatch_elf.h>
> +#include <xen/livepatch.h>
>  
> -void arch_xsplice_patching_enter(void)
> +void arch_livepatching_enter(void)

Still "patching"?

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -192,9 +192,9 @@ config SCHED_DEFAULT
>  
>  endmenu
>  
> -# Enable/Disable xsplice support
> -config XSPLICE
> -     bool "xSplice live patching support (TECH PREVIEW)"
> +# Enable/Disable live patching support
> +config LIVEPATCH
> +     bool "Live patching support (TECH PREVIEW)"
>       default n
>       depends on X86 && HAS_BUILD_ID = "y"
>       ---help---
> @@ -207,13 +207,13 @@ config XSPLICE
>  config FAST_SYMBOL_LOOKUP
>       bool "Fast symbol lookup (bigger binary)"
>       default y
> -     depends on XSPLICE
> +     depends on LIVEPATCH
>       ---help---
>         When searching for symbol addresses we can use the built-in system
>         that is optimized for searching symbols using addresses as the key.
>         However using it for the inverse (find address using the symbol name)
>         it is slow. This extra data and code (~55kB) speeds up the search.
> -       The only user of this is xSplice.
> +       The only user of this is live patch.

Should at least the L be upper case? Or even better say Live
patching, to match its config item's prompt?

> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -58,8 +58,8 @@ obj-y += vsprintf.o
>  obj-y += wait.o
>  obj-$(CONFIG_XENOPROF) += xenoprof.o
>  obj-y += xmalloc_tlsf.o
> -obj-$(CONFIG_XSPLICE) += xsplice.o
> -obj-$(CONFIG_XSPLICE) += xsplice_elf.o
> +obj-$(CONFIG_LIVEPATCH) += livepatch.o
> +obj-$(CONFIG_LIVEPATCH) += livepatch_elf.o

These need to move up now. I'd also like to encourage you to merge
the two lines.

> @@ -356,7 +356,7 @@ static char *pointer(char *str, char *end, const char 
> **fmt_ptr,
>          }
>  
>          /*
> -         * namebuf contents and s for core hypervisor are same but for 
> xSplice
> +         * namebuf contents and s for core hypervisor are same but for live 
> patch

"live patch" here and ...

> --- a/xen/include/xen/elfstructs.h
> +++ b/xen/include/xen/elfstructs.h
> @@ -353,7 +353,7 @@ typedef struct {
>  #define      ELF64_R_TYPE(info)      ((info) & 0xFFFFFFFF)
>  #define ELF64_R_INFO(s,t)    (((s) << 32) + (u_int32_t)(t))
>  
> -/* x86-64 relocation types. We list only the ones xSplice implements. */
> +/* x86-64 relocation types. We list only the ones Live Patch implements. */

"Live Patch" here - please try to be consistent (personally I prefer
the latter).

With those taken care of,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel