Re: [Xen-devel] [PATCH RFC 05/20] acpi/hvmloader: Move passthrough initialization from ACPI code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.04.16 at 03:25, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/acpi/acpi2_0.h
> +++ b/tools/firmware/hvmloader/acpi/acpi2_0.h
> @@ -481,6 +481,10 @@ struct acpi_config {
>      struct acpi_info acpi_info;
>      uint64_t vm_gid[2];
>      uint32_t table_flags;
> +    struct {
> +        unsigned long acpi_pt_addr;
> +        uint32_t acpi_pt_length;
> +    } pt;

Redundant "acpi" and "pt". (Which btw also holds for the earlier
added acpi_info, as I now realize.) Further please consider also
making the address uint32_t.

> @@ -893,6 +894,15 @@ void hvmloader_acpi_build_tables(struct acpi_config 
> *config,
>              config->vm_gid[1] = strtoll(end+1, NULL, 0);
>      }
>  
> +    s = xenstore_read(HVM_XS_ACPI_PT_ADDRESS, NULL);
> +    if ( s ) {

Coding style.

Beyond that looks okay.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel