Re: [Xen-devel] [Patch v6 11/11] vt-d: add __must_check annotation to IOMMU flush pointers and handlers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.05.16 at 15:57, <quan.xu@xxxxxxxxx> wrote:
> @@ -1455,7 +1455,7 @@ int domain_context_mapping_one(
>       */
>      if ( rc <= 0 )
>      {
> -        int flush_dev_iotlb = find_ats_dev_drhd(iommu) ? 1 : 0;
> +        bool_t flush_dev_iotlb = find_ats_dev_drhd(iommu) ? 1 : 0;

Please convert all of these that you touch anyway to the canonical
form used elsewhere: The plain expression if it's already of boolean
type, or else using ! or !! instead of ?:.

With that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel