Re: [Xen-devel] [PATCH for 4.7] xen: Rename of xSplice to livepatch.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/06/2016 01:14, Konrad Rzeszutek Wilk wrote:
> @@ -182,7 +182,7 @@ tools/misc/xen_cpuperf
>  tools/misc/xen-cpuid
>  tools/misc/xen-detect
>  tools/misc/xen-tmem-list-parse
> -tools/misc/xen-xsplice
> +tools/misc/xen-livepatch
>  tools/misc/xenperf
>  tools/misc/xenpm
>  tools/misc/xen-hvmctx

Hate to be a pedant, but this could do with being `sort`ed.

> @@ -247,9 +247,9 @@ xen/arch/x86/efi/check.efi
>  xen/arch/x86/efi/disabled
>  xen/arch/x86/efi/mkreloc
>  xen/arch/x86/test/config.h
> -xen/arch/x86/test/xen_hello_world.xsplice
> -xen/arch/x86/test/xen_bye_world.xsplice
> -xen/arch/x86/test/xen_replace_world.xsplice
> +xen/arch/x86/test/xen_hello_world.xlivepatch
> +xen/arch/x86/test/xen_bye_world.xlivepatch
> +xen/arch/x86/test/xen_replace_world.xlivepatch
>  xen/arch/*/efi/boot.c
>  xen/arch/*/efi/compat.c
>  xen/arch/*/efi/efi.h

And to throw a spanner in the works, a file extension of .xpatch would
be a more natural fit here.  (Then again, the contents of the file is
all .livepatch.$FOO, so perhaps consistency is the more important
attribute.)

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 62f4ffd..d5792ed 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -274,6 +274,16 @@ L:       minios-devel@xxxxxxxxxxxxxxxxxxxx
>  T:   git git://xenbits.xen.org/mini-os.git
>  F:   config/MiniOS.mk
>  
> +LIVE PATCH

PATCHING ?

> @@ -424,8 +424,8 @@ one uint32_t to determine the sub-operations and one 
> padding field which
>  *MUST* always be zero.
>  
>  <pre>
> -struct xen_sysctl_xsplice_op {  
> -    uint32_t cmd;                   /* IN: XEN_SYSCTL_XSPLICE_*. */  
> +struct xen_sysctl_livepatch_op {  
> +    uint32_t cmd;                   /* IN: XEN_SYSCTL_LIVE_PATCH_*. */  

There is an inconsistency here between having a space or not.  I would
expect it to be XEN_SYSCTL_LIVEPATCH_*, to be consistent with other
similar names.

I think livepatch is preferable to live_patch in this case.  Same for
similar constructs.

> -    sysctl.cmd = XEN_SYSCTL_xsplice_op;
> -    sysctl.u.xsplice.cmd = XEN_SYSCTL_XSPLICE_ACTION;
> +    sysctl.cmd = XEN_SYSCTL_livepatch_op;
> +    sysctl.u.livepatch.cmd = XEN_SYSCTL_LIVE_PATCH_ACTION;

Particularly emphasised here.

~Andrew

(P.S. It seems that even renaming things is hard.)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel