Re: [Xen-devel] [PATCH for-4.7] sched/rt: Fix memory leak in rt_init()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/05/16 14:52, Meng Xu wrote:
> On Tue, May 10, 2016 at 9:38 AM, Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx> wrote:
>> c/s 2656bc7b0 "xen: adopt .deinit_pdata and improve timer handling"
>> introduced a error path into rt_init() which leaked prv if the
>> allocation of prv->repl_timer failed.
>>
>> Introduce an error cleanup path.
>>
>> Spotted by Coverity.
> I'm curious about this line. Does it mean that this is spotted by the
> coverty code review or by some automatical testing/checking?

XenServer has our Coverity instance hooked up to every build.

Every time I pull a new version of staging, I get a Coverity report as a
delta from the last build.

>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
> I'm sorry that I should have spot it out when I reviewed the code. :-(

No worries - if this was easy to start with, tools like Coverity
wouldn't exist ;)

>
> Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>

Thanks,

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel