Re: [Xen-devel] [PATCH v2] build: change MINI-OS_ROOT to MINIOS_ROOT

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, May 02, 2016 at 06:26:35PM +0100, Wei Liu wrote:
> In the GNU make manual "How to Use Variables" section there is such
> word:
> 
> "However, variable names containing characters other than letters,
> numbers, and underscores should be considered carefully, as in some
> shells they cannot be passed through the environment to a sub-make (see
> Communicating Variables to a Sub-make)."
> 
> I discover xen stubdom fails to build on Ubuntu 16.04 and Debian
> unstable due to MINI-OS_ROOT is not preserved in the invocation of
> sub-make, while stubdom builds fine on older versions of Ubuntu and
> Debian. It's hard to track down what exactly is changed in those
> systems, but changing MINI-OS_ROOT to MINIOS_ROOT fixes the problem.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> ---
> Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> 

I've pushed this to mini-os.git master branch.

This is also a candidate to backport to 4.6 branch. I will wait a bit
before I actually do it.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel