Re: [Xen-devel] Patch to honor --enable-githttp

[Wei Liu <wei.liu2@xxxxxxxxxx>]

Hello, thanks for the patch

On Mon, May 02, 2016 at 04:36:48PM +0000, Lai, Paul C wrote:
> The following patch fixes the toplevel Xen makefile gereration to honor 
> -enable-githttp if the option is used during configuration.
> 
> 
> commit 040510913564ec7e9f46ce833f8bdf1a40950ff7
> Author: Paul Lai <paul.c.lai@xxxxxxxxx>
> Date:   Mon Apr 11 10:43:57 2016 -0700
> 
>     Honor '--enable-githttp' in toplevel Makefile generation
> 
>     During the make world, git mini-os.git didn't honor the 'configure
>     --enable-githttp' option.  The 'enable-githttp' was only honored in
>     the tools subdirectory.
> 

It is required that you sign off the patch you submit.

It's also a good practice to CC maintainers so that they don't miss your
patch.

Please have a look at

http://wiki.xen.org/wiki/Submitting_Xen_Project_Patches

which has a lot of things covered.

> diff --git a/config/Toplevel.mk.in b/config/Toplevel.mk.in
> index 4db7eaf..1d99189 100644
> --- a/config/Toplevel.mk.in
> +++ b/config/Toplevel.mk.in
> @@ -1 +1,2 @@
> SUBSYSTEMS               := @SUBSYSTEMS@
> +GIT_HTTP                 := @githttp@

The indentation seems wrong. Not sure if it is due to my mail messing
things up though.

Anyway, please resubmit with proper SoB and I will have a closer look.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel