Re: [Xen-devel] [PATCH v3 for-4.7 14/16] oxenstored: fix error when shifting negative value

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 27, 2016 at 01:11:52PM +0200, Roger Pau Monne wrote:
> By explicitly casting it to unsigned.
> 
> Reasoning on why this is needed, provided by Andrew Cooper:
> 
> "Ocaml stores integers shifted left by one, and with the bottom bit set.
> 
> Values with the bottom bit clear are pointers into the GC'd heap. Values
> with the bottom bit set are integers, and need to be shifted by 1 bit to
> have calculations performed."
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel