Re: [Xen-devel] [PATCH v9 14/27] xsplice, symbols: Implement symbol name resolution on address.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.04.16 at 17:35, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/platform_hypercall.c
> +++ b/xen/arch/x86/platform_hypercall.c
> @@ -798,12 +798,13 @@ ret_t 
> do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
>          static char name[KSYM_NAME_LEN + 1]; /* protected by xenpf_lock */
>          XEN_GUEST_HANDLE(char) nameh;
>          uint32_t namelen, copylen;
> +        uint64_t addr;
>  
>          guest_from_compat_handle(nameh, op->u.symdata.name);
>  
>          ret = xensyms_read(&op->u.symdata.symnum, &op->u.symdata.type,
> -                           &op->u.symdata.address, name);
> -
> +                           &addr, name);
> +        op->u.symdata.address = addr;

Wasn't the whole point of this change to have the argument be
a pointer to unsigned long? Why is the type of the new local
variable then uint64_t?

With that adjusted:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel