Re: [Xen-devel] [PATCH v3 1/7] libxl: improve return codes for some pci related functions

[Olaf Hering <olaf@xxxxxxxxx>]

On Wed, Apr 20, Paulina Szubarczyk wrote:

> *libxl__device_from_pcidev() initialize the values of libxl__device
>  struct and can be void.

> -static int libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
> +static void libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
>                                       libxl_device_pci *pcidev,
>                                       libxl__device *device)
>  {
> @@ -74,8 +74,6 @@ static int libxl__device_from_pcidev(libxl__gc *gc, 
> uint32_t domid,
>      device->devid = 0;
>      device->domid = domid;
>      device->kind = LIBXL__DEVICE_KIND_PCI;
> -
> -    return 0;

If you dont have it on your radar already:
This should be done for all other functions of that type as well. I was
always wondering why they had to return something.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel