[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] xen: Document XEN_SYSCTL_CPUPOOL_OP_RMCPU anomalous EBUSY result

On Fri, 2016-04-15 at 12:43 +0200, Juergen Gross wrote:
> On 15/04/16 12:20, Ian Jackson wrote:
> > 
> > Would either of you care to provide a version of my documentation
> > patch
> > which answers the questions that my text answers ?  Or shall we
> > commit
> > my version and you can edit it in-tree :-).
> I can provide an updated patch.

> > All I need now is a recipe for the tools to tell what has happened
> > and
> > then I can make xl or libxl at least print comprehensible and
> > correct
> > error messages...
> So this boils down to finding an appropriate ESOMETHING replacement
> for the EBUSY case introduced by the temporary pinning.

> I think ENOTEMPTY or EADDRINUSE would fit best.
I like the latter better.
> The EBUSY returns of not successful repair attempts (trying to assign
> a
> cpu to another cpupool) should be changed to e.g. EADDRNOTAVAIL?
I'd go for EADDRINUSE and EADDRNOTAVAIL so the two error values are
similarly *wrong* hinting an addressing issue, which is more consistent
(and would come handy when documenting) than having one pointing at the
filesystem and the other at the address space.

Are you going to do the patch for this yourself as well?

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.