[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [libvirt] [PATCH V2] libxl: use LIBXL_API_VERSION 0x040200

On Thu, Apr 14, 2016 at 04:35:12PM -0600, Jim Fehlig wrote:
To ensure the libvirt libxl driver will build with future versions
of Xen where the libxl API may change in incompatible ways,
explicitly use LIBXL_API_VERSION 0x040200. The libxl driver
does use new libxl APIs that have been added since Xen 4.2, but
currently it does not make use of any changes made to existing
APIs such as libxl_domain_create_restore or libxl_set_vcpuaffinity.
The version can be bumped if/when the libxl driver consumes the
changed APIs.

Further details can be found in the following discussion thread

Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
configure.ac             |  2 ++
src/libxl/libxl_conf.h   | 12 ------------
src/libxl/libxl_domain.c | 15 ---------------
3 files changed, 2 insertions(+), 27 deletions(-)

diff --git a/configure.ac b/configure.ac
index b1500f6..446f2a2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -894,6 +894,7 @@ if test "$with_libxl" != "no" ; then
    PKG_CHECK_MODULES([LIBXL], [xenlight], [
     LIBXL_FIRMWARE_DIR=`$PKG_CONFIG --variable xenfirmwaredir xenlight`
     LIBXL_EXECBIN_DIR=`$PKG_CONFIG --variable libexec_bin xenlight`
    ], [LIBXL_FOUND=no])
    if test "$LIBXL_FOUND" = "no"; then
@@ -906,6 +907,7 @@ if test "$with_libxl" != "no" ; then
        AC_CHECK_LIB([xenlight], [libxl_ctx_alloc], [
            LIBXL_LIBS="$LIBXL_LIBS -lxenlight"
            if test "$with_libxl" = "yes"; then

Looks good, I'd just adjust these two hunks so that it's added in one
place (and can be changed in one place later on so we don't fall into
trouble accidentally.  ACK with that changed.


Attachment: signature.asc
Description: Digital signature

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.