Re: [Xen-devel] [PATCH] vm_event: Implement ARM SMC events

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

> >> @@ -254,6 +279,7 @@ typedef struct vm_event_st {
> >      >union {
> >          >union {
> >              >struct vm_event_regs_x86 x86;
> >> +            struct vm_event_regs_arm arm;
> >          >} regs;
> >
> >          Does this alter the x86 ABI? Perhaps the ARM structure is small enough for
> > this to not happen now, but what's the general idea about not breaking other
> > arch'es ABIs when adding support for a new arch here?
>
> I'd suggest modifying VM_EVENT_INTERFACE_VERSION whenever that becomes
> the case.
>

Yeap, that's what I had in mind too, if we end up changing the layout or the size of the struct we will increment the version.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel