Re: [Xen-devel] [PATCH] vm_event: Allow subscribing to write events for specific MSR-s

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 04/12/2016 05:42 PM, Julien Grall wrote:
> Hello Razvan,
> 
> On 12/04/2016 15:34, Razvan Cojocaru wrote:
>> Previously, subscribing to MSR write events was an all-or-none
>> approach, with special cases for introspection MSR-s. This patch
>> allows the vm_event consumer to specify exactly what MSR-s it is
>> interested in, and as a side-effect gets rid of the
>> vmx_introspection_force_enabled_msrs[] special case.
>> This replaces the previously posted "xen: Filter out MSR write
>> events" patch.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>> ---
>>   tools/libxc/include/xenctrl.h      |  4 +--
>>   tools/libxc/xc_monitor.c           |  6 ++--
>>   xen/arch/x86/hvm/event.c           |  3 +-
>>   xen/arch/x86/hvm/hvm.c             |  3 +-
>>   xen/arch/x86/hvm/vmx/vmcs.c        | 26 ++--------------
>>   xen/arch/x86/hvm/vmx/vmx.c         | 10 ++----
>>   xen/arch/x86/monitor.c             | 25 +++++++--------
>>   xen/arch/x86/vm_event.c            | 62
>> ++++++++++++++++++++++++++++++++++++++
>>   xen/include/asm-arm/vm_event.h     | 21 +++++++++++++
> 
> Can you explain why you've added stubs for ARM when nobody in the common
> code is calling them?

Got carried away, just assumed symmetry is required. Will remove them in V2.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel