[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 19/28] build_id: Provide ld-embedded build-ids

>>> On 08.04.16 at 03:52, <konrad@xxxxxxxxxx> wrote:
> On Thu, Apr 07, 2016 at 08:18:27PM -0400, Konrad Rzeszutek Wilk wrote:
>> > 
>> > > +        $(OBJCOPY) -I binary -O elf64-x86-64 -B i386:x86-64 \
>> > > +                --rename-section=.data=.note.gnu.build-id -S $@.bin $@
>> > 
>> > Since you put the notes into .rodata anyway, why name the
>> > section .note.*? Just name it .rodata.*, avoiding to mislead
>> > others who also think that a section's name has much of a
>> > meaning.
>> Way back last year:
>> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01264.html 
>> which is where the .note came about. I can put it all in .rodata
>> and not have it for normal ELF builds if you would like.
> .rodata.notes for both ELF and EFI looks to have done the trick.
> Now it is just the matter of testing it.

Why also for ELF? In ELF, these are ordinary notes, so imo
belong into .note or .note.*. As opposed to COFF/PE, where
the idea of notes doesn't exist.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.