[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

>>> Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> 04/06/16 4:44 AM >>>
>On Fri, Apr 01, 2016 at 09:50:31AM -0600, Jan Beulich wrote:
>> >>> On 24.03.16 at 21:00, <konrad.wilk@xxxxxxxxxx> wrote:
>> > From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>> > 
>> > Add hook functions which run during patch apply and patch revert.
>> > Hook functions are used by xsplice payloads to manipulate data structures
>> > during patching, etc.
>> Since the added documentation here didn't enlighten me, I've gone
>> back to the design doc, and found a single trivial mentioning of hooks.
>> No example of what they would be useful for, nothing. Unless these
>> can be shown to be needed if any recent XSA fix would be converted
>> to an xSplice patch, I'd recommend dropping this for now.
>I do like this for the test-case uses (and regression testing).

I don't think having infrastructure just for test cases' sake is a good idea.

>The normal use-case is to modify structures values where we have to
>be delicate about it and can't just replace the value. As in we
>may have to recompute the value.

That's the normal _theoretical_ use case afaict. Or else you would have
given an example as asked for above.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.