[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 23/28] xsplice: Stacking build-id dependency checking.

> > --- a/xen/include/xen/version.h
> > +++ b/xen/include/xen/version.h
> > @@ -17,4 +17,7 @@ const char *xen_deny(void);
> >  #include <xen/types.h>
> >  int xen_build_id(const void **p, unsigned int *len);
> >  
> > +#include <xen/elfstructs.h>
> > +int xen_build_id_check(const Elf_Note *n, const void **p, unsigned int 
> > *len);
> The #include is misplaced again, and I'm rather hesitant to see
> version.h gain this dependency. Couldn't this go into xen/elf.h?

Sadly no. If I remove these two includes (xen/types.h and
xen/elfstructs.h) the compile breaks. It breaks for kernel.c, console,c,
 setup.c and so on - complaining about unknown type name 'Elf_Note'.

I was thinking to do:

const Elf_Note;

But that didn't work out well. I think it is tied in to the #defines..
I could make it a void pointer too and just cast it inside
xen_build_id_check to 'const Elf_Note'.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.