Re: [Xen-devel] [PATCH v2] x86/hvm: separate ioreq server code from generic hvm code

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Apr 04, 2016 at 12:07:25PM -0400, Boris Ostrovsky wrote:
> On 04/01/2016 03:54 AM, Paul Durrant wrote:
> >The code in hvm/hvm.c related to handling I/O emulation using the ioreq
> >server framework is large and mostly self-contained.
> >
> >This patch separates the ioreq server code into a new hvm/ioreq.c source
> >module and accompanying asm-x86/hvm/ioreq.h header file. There is no
> >intended functional change, only code movement.
> 
> This may be more than just code movement. It breaks PVH. I haven't looked at
> what exactly is breaking but I figured I'd give a heads-up.
> 

Paul and Jan, this needs to be fixed, otherwise we will have to revert
this patch (and subsequents patches that depend on this one).

Wei.

> -boris
> 
> 
> 
> (XEN) ----[ Xen-4.7-unstable  x86_64  debug=y  Tainted:    C ]----
> (XEN) CPU:    2
> (XEN) RIP:    e008:[<ffff82d0801dac82>] handle_hvm_io_completion+0x1bb/0x288
> (XEN) RFLAGS: 0000000000010286   CONTEXT: hypervisor (d1v0)
> (XEN) rax: ffff8302453b8000   rbx: ffff8300a56e3000   rcx: ffff8302453bffc0
> (XEN) rdx: ffff83024da8b000   rsi: ffff82d080326280   rdi: ffff8300a56e3000
> (XEN) rbp: ffff8302453bfd80   rsp: ffff8302453bfc20   r8: ffff830247180ed0
> (XEN) r9:  00000000ffffff21   r10: 00000000deadbeef   r11: 0000000000000246
> (XEN) r12: ffff8300a56e3000   r13: 0000000000000000   r14: ffff83024da8b250
> (XEN) r15: ffff8302453f3000   cr0: 000000008005003b   cr4: 00000000001526e0
> (XEN) cr3: 000000024db49000   cr2: 0000000000000000
> (XEN) ds: 002b   es: 002b   fs: 0000   gs: 0000   ss: e010   cs: e008
> (XEN) Xen code around <ffff82d0801dac82>
> (handle_hvm_io_completion+0x1bb/0x288):
> (XEN)  00 94 fe ff ff 4d 8b 6d <00> 8b 45 00 0f 18 08 4d 39 f5 0f 85 73 fe
> ff ff
> (XEN) Xen stack trace from rsp=ffff8302453bfc20:
> (XEN)    ffff8302453b8000 ffff8302453bfc30 0000000000000000 0000000000000000
> (XEN)    0000000000000000 ffff8302453bfc88 00000000001526e0 ffff8302453bfc88
> (XEN)    0000000000000046 ffff8300a573d000 0000000000000002 ffff8302453f3000
> (XEN)    ffff8300a29fe000 ffff8302453bfc98 ffff82d080178ad1 ffff8302453bfcf8
> (XEN)    ffff82d0801659e1 ffff8302453bff18 ffff8302453b8000 efff0002453bfcd8
> (XEN)    ffff8302453a9000 0000000000000000 0000000000000046 0000000000000082
> (XEN)    00000000000000fd 0000005077eb2c26 0000000000000000 ffff8302453bfd10
> (XEN)    ffff82d080197ced ffff8300a56e3000 ffff8302453bfd60 00000000001526e0
> (XEN)    ffff8302453bfd50 0000000000000046 ffff83009f7e7020 ffff83024da8b000
> (XEN)    ffff8300a56e3000 0000000000000000 ffff8302453bfdb0 ffff8300a56e3000
> (XEN)    ffff8300a573d000 ffff83024da8b000 0000000000000002 ffff8302453f3000
> (XEN)    ffff8302453bfda0 ffff82d0801d4496 ffff8300a56e3000 ffff8300a573d000
> (XEN)    ffff8302453bfdc0 ffff82d0801f49ee ffff8302453bfdc0 ffff8300a56e3000
> (XEN)    ffff8302453bfe20 ffff82d08016a952 0000000000000000 0000000000000000
> (XEN)    0000000000000000 0000000000000000 ffff8302453bfe20 ffff8300a573d000
> (XEN)    000000507862cc3e ffff8300a56e3000 ffff830247180128 0000000000000001
> (XEN)    ffff8302453bfeb0 ffff82d08012c50f 92dd987700000002 ffff830247180140
> (XEN)    00000002003bfe60 ffff830247180120 ffff8302453bfe60 ffff82d080130034
> (XEN)    ffff8302453bfeb0 ffff8300a56e3000 0000000001c9c380 ffff82d0801bed01
> (XEN)    ffff8300a573d000 ffff82d080312b00 ffff82d080312a00 ffffffffffffffff
> (XEN) Xen call trace:
> (XEN)    [<ffff82d0801dac82>] handle_hvm_io_completion+0x1bb/0x288
> (XEN)    [<ffff82d0801d4496>] hvm_do_resume+0x35/0x14b
> (XEN)    [<ffff82d0801f49ee>] vmx_do_resume+0x12c/0x143
> (XEN)    [<ffff82d08016a952>] context_switch+0xf4a/0xf4c
> (XEN)    [<ffff82d08012c50f>] schedule.c#schedule+0x5a5/0x5d7
> (XEN)    [<ffff82d08012f732>] softirq.c#__do_softirq+0x82/0x8d
> (XEN)    [<ffff82d08012f78a>] do_softirq+0x13/0x15
> (XEN)    [<ffff82d0801651a5>] domain.c#idle_loop+0x5e/0x6e
> (XEN)
> (XEN) Pagetable walk from 0000000000000000:
> (XEN)  L4[0x000] = 0000000000000000 ffffffffffffffff
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 2:
> (XEN) FATAL PAGE FAULT
> (XEN) [error_code=0000]
> (XEN) Faulting linear address: 0000000000000000
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel