Re: [Xen-devel] [PATCH v5 22/28] xsplice: Print build_id in keyhandler and on bootup.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.03.16 at 21:00, <konrad.wilk@xxxxxxxxxx> wrote:
> @@ -1414,10 +1420,16 @@ static void xsplice_printall(unsigned char key)
>  
>  static int __init xsplice_init(void)
>  {
> +    const void *binary_id = NULL;
> +    unsigned int len = 0;

Pointless initializer.

>      BUILD_BUG_ON( sizeof(struct xsplice_patch_func) != 64 );
>      BUILD_BUG_ON( offsetof(struct xsplice_patch_func, new_addr) != 8 );
>      BUILD_BUG_ON( offsetof(struct xsplice_patch_func, new_size) != 24 );
>  
> +    if ( !xen_build_id(&binary_id, &len) )
> +        printk(XENLOG_INFO "%s: build-id: %*phN\n", XSPLICE, len, binary_id);

With the above corrected and the string literal not handed to %s
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel