[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/10] libxl_pci: Return error code for more pci-* functions

To: Paulina Szubarczyk <paulinaszubarczyk@xxxxxxxxx>
From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Date: Fri, 1 Apr 2016 16:20:03 +0200
Cc: wei.liu2@xxxxxxxxxx, ian.campbell@xxxxxxxxxx, George.Dunlap@xxxxxxxxxxxxx, dario.faggioli@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, roger.pau@xxxxxxxxxx
Delivery-date: Fri, 01 Apr 2016 14:20:26 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
> Return rc value instead of allways 0.
                              ^ extra "l"

The subject on this patch is too vague, please use something more 
descriptive, like:

libxl: fix return value of libxl__device_pci_destroy_all

> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@xxxxxxxxx>

LGTM, so provided that you fix the subject and commit message:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH 00/10] xl: improve coding style and return more failure on failure for more xl commands
  - From: Paulina Szubarczyk
- [Xen-devel] [PATCH 03/10] libxl_pci: Return error code for more pci-* functions
  - From: Paulina Szubarczyk

Prev by Date: Re: [Xen-devel] [PATCH v3 7/9] libxl: Allow local access for block devices with hotplug scripts
Next by Date: Re: [Xen-devel] [PATCH RFC] x86/vMSI-X: avoid missing first unmask of vectors
Previous by thread: [Xen-devel] [PATCH 03/10] libxl_pci: Return error code for more pci-* functions
Next by thread: [Xen-devel] [PATCH 04/10] xl: improve return code for freemem function
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.