Re: [Xen-devel] [PATCH v5 12/28] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.03.16 at 21:00, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -75,6 +75,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
>                       echo 'EFI installation only partially done (EFI_VENDOR 
> not set)' >&2; \
>               fi; \
>       fi
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) install
>  
>  .PHONY: _uninstall
>  _uninstall: D=$(DESTDIR)
> @@ -92,6 +93,7 @@ _uninstall:
>       rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
>       rm -f $(D)$(EFI_DIR)/$(T).efi
>       rm -f 
> $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) uninstall

Pretty certainly stray changes, or they'd need a really good
explanation.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -75,7 +75,12 @@ efi-y := $(shell if [ ! -r 
> $(BASEDIR)/include/xen/compile.h -o \
>  $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>       ./boot/mkelf32 $(TARGET)-syms $(TARGET) 0x100000 \
>       `$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C test
>  
> +install:
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C test install
> +uninstall:
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C test uninstall

Tests or examples should not be built by default.

> --- /dev/null
> +++ b/xen/arch/x86/test/xen_hello_world.c
> @@ -0,0 +1,30 @@
> +/*
> + * Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
> + *
> + */
> +
> +#include <xen/config.h>

Another of these things needing taking care of throughout the
entire series.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel