Re: [Xen-devel] [PATCH] x86/hvm: separate ioreq server code from generic hvm code

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: dunlapg@xxxxxxxxx [mailto:dunlapg@xxxxxxxxx] On Behalf Of
> George Dunlap
> Sent: 31 March 2016 17:53
> To: Paul Durrant
> Cc: xen-devel; Kevin Tian; Keir (Xen.org); Jan Beulich; Andrew Cooper; Jun
> Nakajima
> Subject: Re: [Xen-devel] [PATCH] x86/hvm: separate ioreq server code from
> generic hvm code
> 
> On Thu, Mar 31, 2016 at 11:20 AM, Paul Durrant <paul.durrant@xxxxxxxxxx>
> wrote:
> > The code in hvm/hvm.c related to handling I/O emulation using the ioreq
> > server framework is large and mostly self-contained.
> >
> > This patch separates the ioreq server code into a new hvm/ioreq.c source
> > module and accompanying asm-x86/hvm/ioreq.h header file. There is no
> > intended functional change, only code movement.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> FWIW I approve of this change.  diff unfortunately chose to see blank
> lines as code that was being merged, so I can't give a proper
> reviewed-by.  But I do have one minor comment...
> 
> > diff --git a/xen/include/asm-x86/hvm/ioreq.h b/xen/include/asm-
> x86/hvm/ioreq.h
> > new file mode 100644
> > index 0000000..54b521f
> > --- /dev/null
> > +++ b/xen/include/asm-x86/hvm/ioreq.h
> > @@ -0,0 +1,67 @@
> > +/*
> > + * hvm.h: Hardware virtual machine assist interface definitions.
> > + *
> > + * Leendert van Doorn, leendert@xxxxxxxxxxxxxx
> > + * Copyright (c) 2005, International Business Machines Corporation.
> 
> Copy and paste error here.

Damn. That does need to be fixed. I'll post v2.

  Paul

> 
>  -George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel