[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target

  • To: Wei Liu <wei.liu2@xxxxxxxxxx>
  • From: "Xu, Quan" <quan.xu@xxxxxxxxx>
  • Date: Fri, 1 Apr 2016 01:41:40 +0000
  • Accept-language: en-US
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 01 Apr 2016 01:42:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: AQHRizcSi/r1wxgp0EON2n+0jljgPp9zC86AgAFIVuA=
  • Thread-topic: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target

On March 31, 2016 9:50pm, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Mar 31, 2016 at 10:21:22AM +0000, Xu, Quan wrote:
> > On March 11, 2016 12:53am, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > > -build: $(STUBDOMPATH)
> > > +build: $(STUBDOM_BUILD)
> >
> > Wei,
> > in original code, in stubdom/vtpm and stubdom/vtpmmgr, the code style is
> > inconsistent and ugly.
> I personally prefer small patches in a series, but I don't object to having 
> large
> patch(es) either. 

ok. I think so too. It may be one file per patch.

> At the end of the day, I think Daniel's opinion matters most.
> After a plan is agreed upon, you can then provide a branch for us to pull in.

I think I am not authorized to branch, could you provide a branch and tell me 
how to commit to that branch?
Sorry, I am unfamiliar with the upstream process.

> Note
> that upstream don't test vtpm in any fashion so you do need to run your tests.
I will test it. I think I hope Daniel could help my patches. 
btw, I have made a quick patch to fix the seal/unseal issue. I will send out 

> The only thing that matters to me is that when you will do it -- you will 
> need to
> patch a different tree after I split off stubdom. In order to minimise the 
> fuss one
> of us will need to wait for the other.
Once you have done, please let me know. 
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.