Re: [Xen-devel] [PATCH v3 1/5] libxl: make libxl__need_xenpv_qemu() operate on domain config

[Juergen Gross <jgross@xxxxxxxx>]

On 24/03/16 21:28, Wei Liu wrote:
> On Wed, Mar 23, 2016 at 01:24:03PM +0100, Juergen Gross wrote:
>> libxl__need_xenpv_qemu() is called with configuration data for console,
>> vfbs, disks and channels today in order to evaluate the need for
>> starting a device model for a pv domain.
>>
>> The console data is local to the caller and setup in a way to never
>> require a device model. All other data is taken from the domain config
>> structure.
>>
>> In order to support other device backends via qemu change the interface
>> of libxl__need_xenpv_qemu() to take the domain config structure as
>> input instead of the single device arrays.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>> V2: Return false if libxl__get_domid() fails as requested by George Dunlap
> 
> This is a bug that should be addressed properly -- returning true or
> false doesn't make sense in the context of this function.
> 
> It would make sense to push calling libxl__get_domid to the sole caller,
> then expose a new parameter called backend_id for
> libxl__need_xenpv_qemu. A patch like that would also be easily
> backportable. What do you think?

Hmm, right now there is only one caller. Patch 4 adds another one. I'd
rather return a negative value for an error, and 0 or 1 indicating the
device model isn't or is to be started.

Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel