Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

Sorry for the late answer on this patch. I noticed the problem while I 
was reviewing your xSplice patch series.
On 12/02/2016 15:56, Konrad Rzeszutek Wilk wrote:
>  From 32a062c119091f2f3f6a4c540a8098e97c273dd2 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Date: Fri, 5 Feb 2016 10:44:45 -0500
> Subject: [PATCH] arm/config: Declare ELFSIZE_64.
>
> Otherwise any code that tries to use Elf_* macros would
> require us to use Elf64_* types instead of the more
> friendly Elf_ one.
>
> This is OK to do since 32-bit ARM uses LPAE mode.
That's not true. Some of structures have a different layout based on the 
file class (i.e ELFSIZE in Xen).
For 32-bit ARM, ELFCLASS32 (i.e 32-bit data types) will always be used. 
So we need to set ELFSIZE to 32.
Otherwise Xen won't be able to interpret correctly the ELF note holding 
the build-id (see [1]).
Regards,

[1] http://lists.xen.org/archives/html/xen-devel/2015-11/msg00632.html

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel