[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 for Xen 4.7 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler



>>> On 16.03.16 at 04:43, <xumengpanda@xxxxxxxxx> wrote:
> On Tue, Mar 15, 2016 at 11:32 PM, Chong Li <lichong659@xxxxxxxxx> wrote:
>> If we define
>>
>>    static bool warned;
>>
>> at the beginning of rt_dom_cntl(), do we need to initialize it? If without
>> initialization, I think its default value is "false", which is just
>> what we need.
>>
> 
> We need initializing any variable we are going to use, of course. We
> should not reply on the compiler to give an initialized value. :-)

Relying on implicit initialization where the language standard
requires such is more than just optional - if I see code changes
with an explicit zero initializer of a static variable, I always
reply back stating that the initializer is pointless.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.