[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/xstate: undo bogus adjustment to xsave()



>>> On 10.03.16 at 13:27, <david.vrabel@xxxxxxxxxx> wrote:
> On 10/03/16 07:39, Jan Beulich wrote:
>> This reverts an unintended change in commit 879b44b041 ("x86/fpu: add
>> a per-domain field to set the width of FIP/FDP"), which I had done
>> intermediately while fixing the build issue: After having reverted that
>> adjustment I must have forgotten to "git add" the adjustment.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> It think you also need to only clobber fip/fdp in memory if mask &
> XSTATE_FP.
> 
> But, quite frankly, this logic too complicated and clearly too fragile
> and you should just take the simplification I posted.

By all means I intend to once we've got confirmation from Intel.
I even did the re-basing already in preparation for that to happen.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.