Re: [Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 29, 2016 at 10:45:51AM -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Feb 23, 2016 at 10:30:31AM +0000, Ian Campbell wrote:
> > On Wed, 2016-02-17 at 10:39 +0000, Ian Campbell wrote:
> > > We assert that nullfd if not std{in,out,err} since that would result
> > > in closing one of the just dup2'd fds. For this to happen
> > > std{in,out,err} would have needed to be closed, at which point all
> > > sorts of other things could go wrong.
> > > 
> > > CID: 1130519
> > > 
> > > It was previously hypothesised[0] that fixing 1130516 would solve this
> > > too, but that appears to not have been the case.
> > > 
> > > Compile tested only.
> > > 
> > > [0] http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg02931.
> > > html
> > > 
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > Cc: andrew.cooper3@xxxxxxxxxx
> > 
> > ping?
> 
> Ian, you wouldn't have a git branch with all your outstanding
> patches you had posted somewhere?
> 
> Just in case we don't get to them done by feature freeze window and
> somebody starts replaying these patches..
> 

Bug fixes are allowed to go in even after the freeze.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel