Re: [Xen-devel] [PATCH v5 5/7] VT-d: Refactor iommu_ops .map_page() and unmap_page()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.02.16 at 12:48, <quan.xu@xxxxxxxxx> wrote:
> I would summarize as follows and make sure we are on the same page.
> 
>  1) make pcidevs_lock only visible inside xen/drivers/passthrough/pci.c, 
>    turning the definition of the variable into a static one, and getting rid 
> of its declaration from xen/include/xen/pci.h
> 
>  2) define 3 helpers in 'include/xen/pci.h':
>     *pcidevs_lock()
>     *pcidevs_unlock()
>     *pcidevs_is_locked()
>   Then, I'd implement these helpers in xen/drivers/passthrough/pci.c. 
>   Of course, the helpers will do spin_lock_recursive() and 
> spin_unlock_recursive(). It is quite similar to what is done for 
> domain_lock().
> 
> 3) use these helpers. Replace
>      *spin_lock(&pcidevs_lock) with pcidevs_lock(),
>      *spin_unlock(&pcidevs_lock) with pcidevs_unlock(),
>      *spin_is_locked(&pcidevs_lock) with pcidevs_is_locked().

Yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel