Re: [Xen-devel] [PATCH] xl: Improve return and exit codes of parse_config_data().

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2016-02-19 at 22:07 +0530, Harmandeep Kaur wrote:
> Turning parse_config_data() exit codes towards using the
> EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary
>
repetition of "instead of"

> numbers or libxl return codes.
> ÂÂÂÂÂÂÂÂ- for main_*: arbitrary -> EXIT_SUCCESS|EXIT_FAILURE.
> ÂÂÂÂÂÂÂÂ- for internal fucntion: arbitrary -> 0/1.
>
This is what you've done in other similar patches, and what should be
done in general. In the case of this patch, only one function is being
considered, and it's an internal void function, i.e., there's no
'internal returns', but only calls to exit().

This changelog should be made a little bit more specific, and say the
above (or maybe just leave the first paragraph there, and remove the
rest).

Apart from this, the code looks ok to me. So, with these changes, this
patch is:

> Signed-off-by: Harmandeep Kaur <write.harmandeep@xxxxxxxxx>
>
Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel