Re: [Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-02-19 at 16:08 +0000, Ian Campbell wrote:
> Â Â Â Â Â Â Â/* allocate space for the extra config plus two EOLs
> > > plus
> > > \0 */
> > > @@ -6525,6 +6526,7 @@ int main_networkattach(int argc, char **argv)
> > > ÂÂÂÂÂ}
> > > Â
> > > ÂÂÂÂÂxlu_cfg_destroy(config);
> > > +ÂÂÂÂconfig = NULL;
> > > Â
> > > ÂÂÂÂÂif (argc > 0) return 1; /* Parse error above */
> > 
> > But this doesn't apply and the current code in main_networkattach
> > doesn't seem to have a bug that something this would fix.
> 
> Looks like a stray line which should have been in "xl: network-attach: free
> config object after use", sorry.

Which I see I somehow did send out!

> I'll wait for you to push the batch you have in hand and then rebase fixing
> this as I go.

I'll still take this approach.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel