[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- From: Borislav Petkov <bp@xxxxxxxxx>
- Date: Wed, 17 Feb 2016 23:03:04 +0100
- Cc: X86 ML <x86@xxxxxxxxxx>, david.e.box@xxxxxxxxx, Andrey Ryabinin <ryabinin.a.a@xxxxxxxxx>, Lv Zheng <lv.zheng@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, qiuxishi@xxxxxxxxxx, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Robert Moore <robert.moore@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Michael Brown <mcb30@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, long.wanglong@xxxxxxxxxx, Fengguang Wu <fengguang.wu@xxxxxxxxx>
- Delivery-date: Wed, 17 Feb 2016 22:03:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Wed, Feb 17, 2016 at 04:21:56PM -0500, Boris Ostrovsky wrote:
> That's exactly the point: if something is mapped it's an error for a
> non-PV kernel.
How would something be mapped there? __PAGE_OFFSET is
0xffff880000000000.
Or are you thinking about some insanely b0rked kernel code mapping stuff
in there?
> By removing paravirt_enabled() we may miss those errors. Worse, I think we
> may even crash while doing pagetable walk (although it's probably better to
> crash here than to use an unexpected translation in real code somewhere)
Well, if this is the only site which keeps paravirt_enabled() from being
buried, we need to think about a better way to detect a hypervisor.
Maybe we should look at x86_hyper, use CPUID(0x4...) or something else.
What's your preference?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
