[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.
- To: xen-devel@xxxxxxxxxxxxx
- From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
- Date: Tue, 16 Feb 2016 10:13:14 +0200
- Cc: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Tue, 16 Feb 2016 08:13:28 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=avj2Q4DurVRKl/um3sIV+wYyy3/24o+6QEeSje6NIqZEIUibBJXHH/BHV3QKKzjcCvOJ1XHIQnWjKTwQGjbaHD5vH/eqTJ2geF+j9qZDs7Hj40JaD6FSGV3+fcef3x1akLntqsVZ6Y+gJs/ZRkWCRtG9yFeVcRUekg8qtImfd49dJIuKhJVaLeT1ZfrwkA7AcQ+ZNli8PNXjL1C4VLPKnrew+7oD9hvNKKNs3QYcR0VGuiXO25eO/zudhH7mJFBZhF+IGfV6seVk4CA95cZfe4Aut4H27lvYVQK1eG24EsBISZaolbC96FbU08PZNrcVb6s3SYCYfG14FGDae/lgwA==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 2/16/2016 9:08 AM, Corneliu ZUZU wrote:
This patch moves monitor_domctl to common-side.
Purpose: move what's common to common, prepare for implementation
of such vm-events on ARM.
* move get_capabilities to arch-side => arch_monitor_get_capabilities.
* add arch-side monitor op handling function => arch_monitor_domctl_op.
e.g. X86-side handles XEN_DOMCTL_MONITOR_OP_EMULATE_EACH_REP op
* add arch-side monitor event handling function => arch_monitor_domctl_event.
e.g. X86-side handles XEN_DOMCTL_MONITOR_EVENT_MOV_TO_MSR event
enable/disable
* remove status_check
Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
---
Changed since v3:
* monitor_domctl @ common/monitor.c:
- remove unused requested_status
- sanity check mop->event range to avoid left-shift undefined behavior
Due to left-shift undefined behavior situations, shouldn't I also:
* in X86 arch_monitor_get_capabilities: replace '1 <<' w/ '1U <<'
* in X86 arch_monitor_domctl_event,
XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG case
add a sanity check of mop->u.mov_to_cr.index before:
unsigned int ctrlreg_bitmask =
monitor_ctrlreg_bitmask(mop->u.mov_to_cr.index);
, which basically translates to:
unsigned int ctrlreg_bitmask = (1U << mop->u.mov_to_cr.index);
? (especially since mop->u.mov_to_cr.index is set by the caller).
Would have been good if I'd thought of that before sending this patch
series :).
Thanks,
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
