[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
- Date: Thu, 11 Feb 2016 08:20:45 +0200
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Thu, 11 Feb 2016 06:21:07 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=1y7jc/+oec7ym3wUbLGv9e/xPN2CwJXnbFWYESLcTmhGEEL2rUzHt9Fc23VaLtbjekL3V5a+K7iCLd/FiLtBa/HCbmhCshbKCxM6nGarPlwjaXCM0tT1oR5KFJ/ZUojxXSqC1QoWQPFJSMjkVEzWhvFNr7b1p0SST3a0AfNCtvPyLTXMGKWZpo3tLdW57dRlS5Is6G7FofzDeIPAuOMYLPX+a84BlMHmQO5/zDg8T8fg0IJbir6r+J0s35iPvkXpA4DFdZUQweunp/FTrKJVLMbDe7C2wRHsJQ26JIkpbN9uP4KvrjD+YAN+hRWWBhjykGR9MKhkaMM9FwCb/ty9eg==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 2/10/2016 6:39 PM, Tamas K Lengyel wrote:
I think it would be better if this function just had a single rc
instead of two (not passing one rc as a pointer on input).
Good point. Would it be ok if:
* I remove the rc param
* make return type int
* rc = 0 if arch-side didn't handle the event, but no errors occurred
* rc = 1 if arch-side handled the event and no errors occurred
* rc < 0 if errors occurred
* return rc
?
Didn't cross my mind why error rcs are < 0, I only now realize that
probably just these kind of situations are the reason for that.
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
