[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
- Date: Wed, 10 Feb 2016 19:12:31 +0200
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Wed, 10 Feb 2016 17:12:37 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=yqD8R+mtyr6ln4Nwjgg7wKZdb9HbVjEhXD6J5Mf0VnWPeG/XQh5/bOD/f8AAU1m9Rh97wOYIdD28jh4aX652tr3/C/QD5YWTfWRwQhNHZQR+mleJGxvNCHvHpKfnuQCEM7wzhhIZ7W0NP/zXJzLe3znHl/ebJLIu9eh2eQRWS7T8jNiBdYpXYGtlD/wYLuIFVYBEdy7cHgHeo3wCEeFiCpjsJ6p5gSWnce/cYuW/jkRvFgqvuQaYlrJDj6QASqvNi2Yd0XBJJyFE2APeuOIw5HWUzWMha4U192Mvt/jTH6ivbGDXUUNdaURh7L5bj7k4laA4I8ASA5sMAjyr0XZcow==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 2/10/2016 6:26 PM, Jan Beulich wrote:
On 10.02.16 at 16:52, <czuzu@xxxxxxxxxxxxxxx> wrote:
xen/arch/x86/Kconfig | 4 +
xen/arch/x86/Makefile | 2 +-
xen/arch/x86/hvm/event.c | 2 +-
xen/arch/x86/hvm/hvm.c | 2 +-
xen/arch/x86/hvm/vmx/vmx.c | 2 +-
xen/arch/x86/monitor_x86.c | 72 ++++++++
xen/common/Kconfig | 20 +++
xen/common/Makefile | 1 +
xen/common/domctl.c | 2 +-
xen/{arch/x86 => common}/monitor.c | 195 +++++++++-------------
xen/include/asm-arm/{monitor.h => monitor_arch.h} | 34 +++-
xen/include/asm-x86/monitor_arch.h | 74 ++++++++
xen/include/{asm-x86 => xen}/monitor.h | 17 +-
13 files changed, 293 insertions(+), 134 deletions(-)
create mode 100644 xen/arch/x86/monitor_x86.c
rename xen/{arch/x86 => common}/monitor.c (44%)
rename xen/include/asm-arm/{monitor.h => monitor_arch.h} (46%)
create mode 100644 xen/include/asm-x86/monitor_arch.h
rename xen/include/{asm-x86 => xen}/monitor.h (74%)
With percentages as low as 44 I'm not sure all this strange
renaming and introduction of oddly named new files is actually a
good idea.
The diff would have actually looked a lot worse if I didn't do that, at
least IMO.
The "strange renaming and ..." was an effort I made to make reviewing these
patches easier :). The reason is explained in the introductory message
and in this commit
message.
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -14,6 +14,10 @@ config X86
select HAS_MEM_ACCESS
select HAS_MEM_PAGING
select HAS_MEM_SHARING
+ select HAS_VM_EVENT_WRITE_CTRLREG
+ select HAS_VM_EVENT_SINGLESTEP
+ select HAS_VM_EVENT_SOFTWARE_BREAKPOINT
+ select HAS_VM_EVENT_GUEST_REQUEST
select HAS_NS16550
select HAS_PASSTHROUGH
select HAS_PCI
Please don't break the alphabetic ordering.
Noted. Didn't realise they were in alphabetic order.
+#include <xen/config.h> /* for XENLOG_WARNING */
Please simply drop this include, it's being automatically included via
compiler command line option. Also please avoid comments like this
unless they explain an otherwise unexpected or unreasonable
inclusion.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
Noted, noted.
That you,
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
