[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.



>>> On 10.02.16 at 17:26, <JBeulich@xxxxxxxx> wrote:
>>>> On 10.02.16 at 16:52, <czuzu@xxxxxxxxxxxxxxx> wrote:
>>  xen/arch/x86/Kconfig                              |   4 +
>>  xen/arch/x86/Makefile                             |   2 +-
>>  xen/arch/x86/hvm/event.c                          |   2 +-
>>  xen/arch/x86/hvm/hvm.c                            |   2 +-
>>  xen/arch/x86/hvm/vmx/vmx.c                        |   2 +-
>>  xen/arch/x86/monitor_x86.c                        |  72 ++++++++
>>  xen/common/Kconfig                                |  20 +++
>>  xen/common/Makefile                               |   1 +
>>  xen/common/domctl.c                               |   2 +-
>>  xen/{arch/x86 => common}/monitor.c                | 195 
>> +++++++++-------------
>>  xen/include/asm-arm/{monitor.h => monitor_arch.h} |  34 +++-
>>  xen/include/asm-x86/monitor_arch.h                |  74 ++++++++
>>  xen/include/{asm-x86 => xen}/monitor.h            |  17 +-
>>  13 files changed, 293 insertions(+), 134 deletions(-)
>>  create mode 100644 xen/arch/x86/monitor_x86.c
>>  rename xen/{arch/x86 => common}/monitor.c (44%)
>>  rename xen/include/asm-arm/{monitor.h => monitor_arch.h} (46%)
>>  create mode 100644 xen/include/asm-x86/monitor_arch.h
>>  rename xen/include/{asm-x86 => xen}/monitor.h (74%)
> 
> With percentages as low as 44 I'm not sure all this strange
> renaming and introduction of oddly named new files is actually a
> good idea.

Also it looks like this moving around of files needs to be
accompanied by adjustments to ./MAINTAINERS.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.