Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

So I don't particularly like this #if check here. IMHO this should be done in arch-specific function that you call from here that is just empty for ARM. It could be a static inline function as it's rather small.
Â

+#if CONFIG_X86

+Â Â Â Â if ( VM_EVENT_X86_CR3 == mop->u.mov_to_cr.index )
+Â Â Â Â {
+Â Â Â Â Â Â struct vcpu *v;
+Â Â Â Â Â Â /* Latches new CR3 mask through CR0 code. */
+Â Â Â Â Â Â for_each_vcpu ( d, v )
+Â Â Â Â Â Â Â Â hvm_update_guest_cr(v, 0);
+Â Â Â Â }
+#endif

I agree, but I was actually hoping to approach that in a future ARM-patch I'm going to send after this one.
On ARM, that part of code (where hypervisor CR trapping is enabled based on write_ctrlreg_enabled bits)
is done in another place (on the scheduling tail). I wanted to approach removing that #ifdef and finding maybe
a solution to do that similarly for X86. Would it be ok to leave this for that discussion? It would be simpler to illustrate
what I have in mind.

SGTM.

Thanks,

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel