Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Mon, Feb 8, 2016 at 10:15 AM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:

On 08/02/16 16:57, Corneliu ZUZU wrote:
> diff --git a/xen/include/asm-x86/hvm/event.h b/xen/include/asm-x86/hvm/event.h
> index 11eb1fe..7c2252b 100644
> --- a/xen/include/asm-x86/hvm/event.h
> +++ b/xen/include/asm-x86/hvm/event.h
> @@ -27,9 +27,8 @@ bool_t hvm_event_cr(unsigned int index, unsigned long value,
>Â #define hvm_event_crX(what, new, old) \
>Â Â Â hvm_event_cr(VM_EVENT_X86_##what, new, old)
>Â void hvm_event_msr(unsigned int msr, uint64_t value);
> -/* Called for current VCPU: returns -1 if no listener */
> -int hvm_event_int3(unsigned long rip);
> -int hvm_event_single_step(unsigned long rip);
> +int hvm_event_software_breakpoint(unsigned long rip,
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â bool_t single_step);

Are we liable to ever gain any other type of software breakpoint? Might
it be more sense to pass an enum rather than a bool here?

Exactly what I was thinking, that would make the code somewhat more readable.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel