Re: [Xen-devel] [PATCH 1/2] xenoprof: fix up ability to disable it

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 02/08/2016 11:04 AM, Doug Goldstein wrote:
> Allow Xenoprof to be fully disabled when toggling the option off.
>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> CC: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>
> CC: Jun Nakajima <jun.nakajima@xxxxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>

> @@ -2666,10 +2669,11 @@ static int vmx_msr_write_intercept(unsigned int msr, 
> uint64_t msr_content)
>               goto gp_fault;
>           break;
>       default:
> -        if ( passive_domain_do_wrmsr(msr, msr_content) )
> +        if ( IS_ENABLED(CONFIG_XENOPROF) &&
> +             passive_domain_do_wrmsr(msr, msr_content) )
>               return X86EMUL_OKAY;
>   
> -        if ( wrmsr_viridian_regs(msr, msr_content) )
> +        if ( wrmsr_viridian_regs(msr, msr_content) )
>               break;
Looks like a stray change.

Other than that,

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

While at it --- I think we should put VPMU code under CONFIG option too, 
especially given its support status. I can do that (unless Doug wants to).
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel