Re: [Xen-devel] [PATCH] x86/HVM: add padding to hvm_hw_cpu

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.01.16 at 15:47, <andrew.cooper3@xxxxxxxxxx> wrote:
>> index b6b1bf8..6862720 100644
>> --- a/xen/include/public/arch-x86/hvm/save.h
>> +++ b/xen/include/public/arch-x86/hvm/save.h
>> @@ -163,6 +163,7 @@ struct hvm_hw_cpu {
>>  #define _XEN_X86_FPU_INITIALISED        0
>>  #define XEN_X86_FPU_INITIALISED         (1U<<_XEN_X86_FPU_INITIALISED)
>>      uint32_t flags;
>> +    uint32_t pad0;
> 
> I would extend flags to uint64_t, so the existing ctxt.flags &
> ~XEN_X86_FPU_INITIALISED check for unused bits will cover all of them.

Actually I would have suggested against that (and demanded the
new field to be checked), but I see the new patch and your R-b
already came through, so I'm not going to demand a 3rd version.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel