Re: [Xen-devel] [PATCH v4 2/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.01.16 at 02:59, <quan.xu@xxxxxxxxx> wrote:
> On 14.01.2016 at 12:58am, <JBeulich@xxxxxxxx> wrote:
>> >>> On 23.12.15 at 09:25, <quan.xu@xxxxxxxxx> wrote:
>> > --- a/xen/drivers/passthrough/vtd/qinval.c
>> > +++ b/xen/drivers/passthrough/vtd/qinval.c
>> > @@ -28,6 +28,11 @@
>> >  #include "vtd.h"
>> >  #include "extern.h"
>> >
>> > +static int __read_mostly iommu_qi_timeout_ms = 1;
>> > +integer_param("iommu_qi_timeout_ms", iommu_qi_timeout_ms);
>> 
>> But wait - this needs to be accompanied by an entry in
>> docs/misc/xen-command-line.markdown.
>> 
> 
> Jan, Is the following right?

No - you appear to add to the "iommu" option description. Either you
need to change the implementation to match that (which probably
would be a good idea, as that's what "iommu" is being used for in
other cases), or you need to add a new standalone entry with the
correct option name.

Jan

> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -901,6 +901,14 @@ debug hypervisor only).
> 
>  >> Control the use of Queued Invalidation.
> 
> +> `qi_timeout_ms` (VT-d)
> +
> +> Default: `1`
> +
> +> `= <integer>`
> +
> +>> Specify the timeout of the VT-d Queued Invalidation in ms.
> +
>  > `snoop` (Intel)
> 
>  > Default: `true`
> 
> 
> -Quan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel