Re: [Xen-devel] [PATCH v2 11/13] tools: split up xen-init-dom0.c

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2016-01-06 at 16:33 +0000, Wei Liu wrote:
> On Wed, Jan 06, 2016 at 04:26:10PM +0000, Ian Campbell wrote:
> > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
> > > Split up tools/helpers/xen-init-dom0.c in order to prepare reusing
> > > generation of the json configuration by init-xenstore-domain.c.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > 
> > Wei, was there a reason for using atexit() to free the handles which
> > I'm
> > not seeing? IOW I think there is a single exit path which could have
> > done
> > all that today, so Juergen is OK to change it in this way.
> > 
> 
> No, there isn't particular reason to use atexit. I copied it from xl.
> It's OK for Juergen to change it.

In which case: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

The mixture of logging via xtl and via (f)printf in this code is a bit odd,
but that's unchanged by this patch. Someone who was feeling particularly
enthusiastic might like to make it use xtl throughout and provide a way to
increase the log level.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel