[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 58/62] xen/acpi: Fix event-channel interrupt when booting with ACPI
- To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, <shannon.zhao@xxxxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxxxxx>
- Date: Mon, 30 Nov 2015 15:30:54 +0000
- Cc: mark.rutland@xxxxxxx, hangaohuai@xxxxxxxxxx, david.vrabel@xxxxxxxxxx, keir@xxxxxxx, ian.campbell@xxxxxxxxxx, ard.biesheuvel@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, peter.huangpeng@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxx, stefano.stabellini@xxxxxxxxxx, christoffer.dall@xxxxxxxxxx, jbeulich@xxxxxxxx, zhaoshenglong@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, roger.pau@xxxxxxxxxx
- Delivery-date: Mon, 30 Nov 2015 15:32:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 27/11/15 15:12, Stefano Stabellini wrote:
>> + }
>> + else
>> + {
>> + int type = 3;
>> + int flag = 2; /* Active-low level-sensitive */
>> + d->arch.hvm_domain.params[HVM_PARAM_CALLBACK_IRQ] = (u64)type << 56
>> + | flag << 8
>> + |
>> d->arch.evtchn_irq;
>> + }
>> }
>
> Actually there is no point in setting HVM_PARAM_CALLBACK_IRQ only on
> ACPI: I would just set it on all cases.
+1
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
