Re: [Xen-devel] [PATCHv6] 08/28] build: convert HAS_IOPORTS use to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.11.15 at 15:56, <JBeulich@xxxxxxxx> wrote:
>>>> On 24.11.15 at 18:51, <cardoe@xxxxxxxxxx> wrote:
>> --- a/xen/drivers/char/Kconfig
>> +++ b/xen/drivers/char/Kconfig
>> @@ -3,3 +3,8 @@ config UART_NS16550
>>      bool "16550-series UART support"
>>      help
>>        This selects the 16550-series UART support. For most systems, say Y.
>> +
>> +# Select HAS_IOPORTS if 16550 has I/O ports
>> +config HAS_IOPORTS
>> +    bool
>> +    depends on UART_NS16550
> 
> Even if only used in ns16550.c, this is a generic setting and hence
> belongs in common/Kconfig and should be selected by the arches
> as needed.

I see it is being selected, but the "depends" here is bogus: When
there is no prompt and no default, there should also not be any
dependency.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel